c++ - Cleanest way to combine two shorts to an int

Question

I have two 16-bit shorts (s1 and s2), and I'm trying to combine them into a single 32-bit integer (i1). According to the spec I'm dealing with, s1 is the most significant word, and s2 is the least significant word, and the combined word appears to be signed. (i.e. the top bit of s1 is the sign.)

What is the cleanest way to combine s1 and s2?

I figured something like

const utils::int32 i1 = ((s1<<16) | (s2));

would do, and it seems to work, but I'm worried about left-shifting a short by 16.

Also, I'm interested in the idea of using a union to do the job, any thoughts on whether this is a good or bad idea?

Answer 1

What you are doing is only meaningful if the shorts and the int are all unsigned. If either of the shorts is signed and has a negative value, the idea of combining them into a single int is meaningless, unless you have been provided with a domain-specific specification to cover such an eventuality.