Welcome to ShenZhenJia Knowledge Sharing Community for programmer and developer-Open, Learning and Share
menu search
person
Welcome To Ask or Share your Answers For Others

Categories

I am using Entity Framework and I need to check if a product with name = "xyz" exists ...

I think I can use Any(), Exists() or First().

Which one is the best option for this kind of situation? Which one has the best performance?

Thank You,

Miguel

See Question&Answers more detail:os

与恶龙缠斗过久,自身亦成为恶龙;凝视深渊过久,深渊将回以凝视…
thumb_up_alt 0 like thumb_down_alt 0 dislike
746 views
Welcome To Ask or Share your Answers For Others

1 Answer

Okay, I wasn't going to weigh in on this, but Diego's answer complicates things enough that I think some additional explanation is in order.

In most cases, .Any() will be faster. Here are some examples.

Workflows.Where(w => w.Activities.Any())
Workflows.Where(w => w.Activities.Any(a => a.Title == "xyz"))

In the above two examples, Entity Framework produces an optimal query. The .Any() call is part of a predicate, and Entity Framework handles this well. However, if we make the result of .Any() part of the result set like this:

Workflows.Select(w => w.Activities.Any(a => a.Title == "xyz"))

... suddenly Entity Framework decides to create two versions of the condition, so the query does as much as twice the work it really needed to. However, the following query isn't any better:

Workflows.Select(w => w.Activities.Count(a => a.Title == "xyz") > 0)

Given the above query, Entity Framework will still create two versions of the condition, plus it will also require SQL Server to do an actual count, which means it doesn't get to short-circuit as soon as it finds an item.

But if you're just comparing these two queries:

  1. Activities.Any(a => a.Title == "xyz")
  2. Activities.Count(a => a.Title == "xyz") > 0

... which will be faster? It depends.

The first query produces an inefficient double-condition query, which means it will take up to twice as long as it has to.

The second query forces the database to check every item in the table without short-circuiting, which means it could take up to N times longer than it has to, depending on how many items need to be evaluated before finding a match. Let's assume the table has 10,000 items:

  • If no item in the table matches the condition, this query will take roughly half the time as the first query.
  • If the first item in the table matches the condition, this query will take roughly 5,000 times longer than the first query.
  • If one item in the table is a match, this query will take an average of 2,500 times longer than the first query.
  • If the query is able to leverage an index on the Title and key columns, this query will take roughly half the time as the first query.

So in summary, IF you are:

  1. Using Entity Framework 4 (since newer versions might improve the query structure) Entity Framework 6.1 or earlier (since 6.1.1 has a fix to improve the query), AND
  2. Querying directly against the table (as opposed to doing a sub-query), AND
  3. Using the result directly (as opposed to it being part of a predicate), AND
  4. Either:
    1. You have good indexes set up on the table you are querying, OR
    2. You expect the item not to be found the majority of the time

THEN you can expect .Any() to take as much as twice as long as .Count(). For example, a query might take 100 milliseconds instead of 50. Or 10 instead of 5.

IN ANY OTHER CIRCUMSTANCE .Any() should be at least as fast, and possibly orders of magnitude faster than .Count().

Regardless, until you have determined that this is actually the source of poor performance in your product, you should care more about what's easy to understand. .Any() more clearly and concisely states what you are really trying to figure out, so stick with that.


与恶龙缠斗过久,自身亦成为恶龙;凝视深渊过久,深渊将回以凝视…
thumb_up_alt 0 like thumb_down_alt 0 dislike
Welcome to ShenZhenJia Knowledge Sharing Community for programmer and developer-Open, Learning and Share
...